This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Bump kubernetes dependencies to 1.14.1 #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "bump-kube-1.14.0" git@github.com:jcsirot/docker-app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357817200
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
jcsirot
force-pushed
the
bump-kube-1.14.0
branch
2 times, most recently
from
2a88241 to
e1263b5
Compare
simonferquel
force-pushed
the
bump-kube-1.14.0
branch
from
cdf63ec to
f536733
Compare
jcsirot
changed the title
Merged
simonferquel
suggested changes
Apr 15, 2019
Contributor
simonferquel
left a comment
simonferquel
left a comment
There was a problem hiding this comment.
Not sure about the change of behavior in merging parameters. cc @silvin-lubecki @chris-crone
vdemeester
suggested changes
Apr 15, 2019
jcsirot
force-pushed
the
bump-kube-1.14.0
branch
from
f536733 to
b233d1b
Compare
simonferquel
approved these changes
Apr 17, 2019
- Use a custom duffle branch using github.com/deislabs/cnab-go/bundle (waiting for cnabio/duffle#681 to be merged) Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
…/mergo#102) Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Contributor
|
I'll carry this PR as @jcsirot is at a conference. |
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
chris-crone
force-pushed
the
bump-kube-1.14.0
branch
from
b233d1b to
e47b30f
Compare
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 68.94% 69.09% +0.14%
==========================================
Files 53 53
Lines 2818 2818
==========================================
+ Hits 1943 1947 +4
+ Misses 612 609 -3
+ Partials 263 262 -1
Continue to review full report at Codecov.
|
Contributor
|
CI is green, PTAL @silvin-lubecki @simonferquel @vdemeester |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Update k8s dependencies to 1.14.0 and updates code and tests when required.
- A picture of a cute animal (not mandatory but encouraged)